Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report waived results as pass for TF environment #286

Closed
wants to merge 1 commit into from

Conversation

mildas
Copy link
Contributor

@mildas mildas commented Nov 12, 2024

For TF runs, tmt correctly shows waived results as warn, but then TF shows them as failures and that's a huge mess mainly for our Errata test run where we check for missing identifiers (hundreds of waived rules https://github.com/RHSecurityCompliance/contest/blob/main/conf/waivers/20-long-term#L124).

@comps
Copy link
Contributor

comps commented Nov 12, 2024

Let's please make a new function, something like on_testingfarm(), right below def have_beaker_api(), that would

return os.environ.get('TESTING_FARM_REQUEST_ID') is not None

and then use that function on the two places.

@mildas
Copy link
Contributor Author

mildas commented Nov 13, 2024

Closing because of #287

@mildas mildas closed this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants