Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix reversed logic in Datastream.has_remediation #158

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

comps
Copy link
Contributor

@comps comps commented Apr 24, 2024

Tested manually from a hacked /scanning/oscap-eval by:

ds = oscap.global_ds()
rem = ds.has_remediation('partition_for_tmp')
print(f'partition_for_tmp has remediation: {rem}')
rem = ds.has_remediation('dconf_gnome_disable_restart_shutdown')
print(f'dconf_gnome_disable_restart_shutdown has remediation: {rem}')

resulting in

partition_for_tmp has remediation: False
dconf_gnome_disable_restart_shutdown has remediation: True

@matusmarhefka matusmarhefka merged commit 1631fd5 into main Apr 24, 2024
3 checks passed
@matusmarhefka matusmarhefka deleted the fix_reversed_remediation branch April 24, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants