Add ansible testing to /per-rule
#157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'oscap' being the fix (remediation) type. Signed-off-by: Jiri Jaburek <[email protected]>
Signed-off-by: Jiri Jaburek <[email protected]>
This allows multiple tests to share one VM, just like with snapshots, but without the snapshots. Useful for tests that aren't fully destructive, but still share some common setup, ie. 'automatus.py', which has its own snapshotting logic. In these cases, we don't need to re-install the VM every time, we just need to ensure it is successfully installed once. Signed-off-by: Jiri Jaburek <[email protected]>
Signed-off-by: Jiri Jaburek <[email protected]>
matusmarhefka
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This (in several commits) splits the
/per-ruletests intooscapandansible, to match the--remediate-usingargument ofautomatus.py.The split is done on the FMF metadata level to make all these inherit
max1and run in parallel - the thought is that Beaker jobs will spread themselves out much more evenly than when runningoscap+ansiblein one test, on one system.OTOH
/per-rule/from-envis likely intended to be run on a single system for bothoscapandansible, so I've added a re-use logic tolib.virtfor non-snapshotted (meaning not snapshotted by Contest) logic for VMs, avoiding the second VM install, relying onautomatus.pyto useqcow2-internal snapshots.Nitrate (TCMS) export to be done after PR merge.