Skip to content

Commit

Permalink
Merge pull request #137 from hdwilber/fix/icons_in_firefox
Browse files Browse the repository at this point in the history
Fix. Firefox dark and light themes support
  • Loading branch information
Espen Henriksen authored Oct 8, 2018
2 parents 34deeae + 9a6c479 commit 24c784e
Show file tree
Hide file tree
Showing 5 changed files with 140 additions and 17 deletions.
40 changes: 40 additions & 0 deletions dist/img/favicon/favicon.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
31 changes: 31 additions & 0 deletions dist/img/rested-logo-inv.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
31 changes: 31 additions & 0 deletions dist/img/rested-logo.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
10 changes: 5 additions & 5 deletions dist/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,11 @@
<link id="highlightJSLink" rel="stylesheet" type="text/css" href="ext/highlight.js/default.css">
<link rel="stylesheet" type="text/css" href="ext/font-awesome-4.4.0/css/font-awesome.min.css">

<link rel="icon" type="image/png" sizes="128x128" href="img/favicon/favicon-128x128.png">
<link rel="icon" type="image/png" sizes="96x96" href="img/favicon/favicon-96x96.png">
<link rel="icon" type="image/png" sizes="64x64" href="img/favicon/favicon-64x64.png">
<link rel="icon" type="image/png" sizes="32x32" href="img/favicon/favicon-32x32.png">
<link rel="icon" type="image/png" sizes="16x16" href="img/favicon/favicon-16x16.png">
<link rel="icon" type="image/svg+xml" sizes="16x16" href="img/favicon/favicon.svg">
<link rel="icon" type="image/svg+xml" sizes="32x32" href="img/favicon/favicon.svg">
<link rel="icon" type="image/svg+xml" sizes="64x64" href="img/favicon/favicon.svg">
<link rel="icon" type="image/svg+xml" sizes="96x96" href="img/favicon/favicon.svg">
<link rel="icon" type="image/svg+xml" sizes="128x128" href="img/favicon/favicon.svg">
<meta name="theme-color" content="#ffffff">
</head>

Expand Down
45 changes: 33 additions & 12 deletions firefox/manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,21 +11,42 @@
}
},
"icons": {
"16": "dist/img/favicon/favicon-16x16.png",
"32": "dist/img/favicon/favicon-32x32.png",
"64": "dist/img/favicon/favicon-64x64.png",
"96": "dist/img/favicon/favicon-96x96.png",
"128": "dist/img/favicon/favicon-128x128.png"
"16": "dist/img/rested-logo.svg",
"32": "dist/img/rested-logo.svg",
"64": "dist/img/rested-logo.svg",
"96": "dist/img/rested-logo.svg",
"128": "dist/img/rested-logo.svg"
},
"browser_action": {
"default_title": "Open RESTED tab",
"default_icon": {
"16": "dist/img/favicon/favicon-16x16.png",
"32": "dist/img/favicon/favicon-32x32.png",
"64": "dist/img/favicon/favicon-64x64.png",
"96": "dist/img/favicon/favicon-96x96.png",
"128": "dist/img/favicon/favicon-128x128.png"
}
"default_icon": "dist/img/rested-logo.svg",
"theme_icons": [
{
"light": "dist/img/rested-logo-inv.svg",
"dark": "dist/img/rested-logo.svg",
"size": 16
},
{
"light": "dist/img/rested-logo-inv.svg",
"dark": "dist/img/rested-logo.svg",
"size": 32
},
{
"light": "dist/img/rested-logo-inv.svg",
"dark": "dist/img/rested-logo.svg",
"size": 64
},
{
"light": "dist/img/rested-logo-inv.svg",
"dark": "dist/img/rested-logo.svg",
"size": 96
},
{
"light": "dist/img/rested-logo-inv.svg",
"dark": "dist/img/rested-logo.svg",
"size": 128
}
]
},
"background": {
"scripts": ["main.js"]
Expand Down

0 comments on commit 24c784e

Please sign in to comment.