Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Staging #68

Merged
merged 17 commits into from
Aug 15, 2024
Merged

Staging #68

merged 17 commits into from
Aug 15, 2024

Conversation

suejinkim20
Copy link
Collaborator

@suejinkim20 suejinkim20 commented Aug 15, 2024 •
edited
Loading

Note: Currently awaiting a final content review from Ashley in Slack. Ashley approved in Slack.

This PR brings the following changes into Main:

  • update the content and layout of the Projects in the STARlight section
  • update the key contacts section by adding photos and card component
  • remove unneeded variables
  • refactor swiper carousel component to address responsiveness and address resizing error ( close reisizing window throws a TypeError #64 )
  • removes github actions file ( close remove obsolete .github/workflows #65 )
  • updates text for the star ventures dates section as requested in slack

suejinkim20 and others added 17 commits August 14, 2024 09:25
@suejinkim20
update project content for starlight section
39827d7
@suejinkim20
update layout for project spotlight cards and carousel
f9d16fa
@suejinkim20
add photourls for and remove contact email text
d18857c
@suejinkim20
add photoURL to section query
4677919
@suejinkim20
add key contacts cards
3b50260
@suejinkim20
Merge pull request #62 from RENCI/enhancement/starlight-projects
813cf54 
Enhancement/starlight projects
@suejinkim20
Merge pull request #63 from RENCI/feature/improve-contacts-section
e237485 
Feature/improve contacts section
@suejinkim20
set debug mode to false
0b3188b
@suejinkim20
remove dates variables from monday plugin
0419b13
@suejinkim20
use breakpoints property to make slidesPerView responsive
46fa506
@suejinkim20
combine responsive styles into one StudentSlide
3a7d084
@suejinkim20
remove mobile carousel and mobile student slide
e1f0051
@suejinkim20
remove obsolete .github/workflows folder
7a9e3b1
@suejinkim20
Merge pull request #66 from RENCI/bugfix/swiperjs-resize-error
d534388 
Bugfix/swiperjs resize error
@suejinkim20
update language for star ventures dates
94701ab
@mbwatson
remove unused vars
8f7b507
@suejinkim20
Merge pull request #67 from RENCI/develop
1743f4a 
Develop
@suejinkim20 suejinkim20 requested a review from mbwatson August 15, 2024 13:38
mbwatson
mbwatson approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@mbwatson mbwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@suejinkim20 suejinkim20 merged commit 3ef872e into main Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbwatson mbwatson mbwatson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@suejinkim20 @mbwatson