Skip to content

Commit

Permalink
bug fix for getting avail items for review
Browse files Browse the repository at this point in the history
  • Loading branch information
hyi committed Nov 18, 2022
1 parent 0303eb6 commit 94c8bd6
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -761,8 +761,8 @@ def get_all_avail_items_for_review(item):
for key, val in region_dict.items():
if 'item_id' in val:
complete_info = get_history_info(item, val['item_id'], ANNOT_COMPLETE_KEY)
review_complete_info = get_history_info(item, val['item_id'], REVIEW_COMPLETE_KEY)
if complete_info and not review_complete_info:
review_assign_info = get_history_info(item, val['item_id'], REVIEW_ASSIGN_KEY)
if complete_info and not review_assign_info:
avail_item_list.append({
'id': val['item_id'],
'annotation_completed_by': complete_info,
Expand Down
2 changes: 1 addition & 1 deletion girder/plugins/ninjato_api/girder_ninjato_api/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,7 @@ def get_assignment_status(whole_item, assign_item_id):
return "active"
elif len(complete_info) > len(review_complete_info):
# reannotated assignment is ready to be reviewed
return 'awaiting review'
return 'under review'
else:
# should not happen
raise RestException(f'More review_completed_by actions than annotation_completed_by actions '
Expand Down

0 comments on commit 94c8bd6

Please sign in to comment.