Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cm): an usable RDMA CM interface with cmtime as example #39

Merged
merged 3 commits into from
Dec 20, 2024
Merged

feat(cm): an usable RDMA CM interface with cmtime as example #39

merged 3 commits into from
Dec 20, 2024

Conversation

dragonJACson
Copy link
Contributor

No description provided.

@dragonJACson dragonJACson marked this pull request as draft October 19, 2024 14:18
@dragonJACson dragonJACson force-pushed the dev/cm branch 7 times, most recently from f02aab2 to e566350 Compare October 20, 2024 13:01
@codecov Codecov
Copy link

codecov bot commented Oct 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 89.84615% with 33 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/cm/communication_manager.rs 89.84% 33 Missing ⚠️
Files with missing lines Coverage Δ
src/verbs/completion.rs 82.27% <ø> (ø)
src/verbs/device_context.rs 78.80% <ø> (ø)
src/verbs/protection_domain.rs 91.89% <ø> (ø)
src/verbs/queue_pair.rs 75.35% <ø> (+2.22%) ⬆️
src/cm/communication_manager.rs 89.40% <89.84%> (+89.40%) ⬆️

... and 1 file with indirect coverage changes

@dragonJACson dragonJACson force-pushed the dev/cm branch 6 times, most recently from 74c0903 to 145481f Compare October 25, 2024 15:16
@dragonJACson dragonJACson requested a review from FujiZ October 25, 2024 15:17
@dragonJACson dragonJACson self-assigned this Oct 25, 2024
@dragonJACson dragonJACson changed the title WIP: an usable RDMA CM interface with cmtime as example feat(cm): an usable RDMA CM interface with cmtime as example Oct 26, 2024
@dragonJACson dragonJACson force-pushed the dev/cm branch 3 times, most recently from 8c37206 to 546a163 Compare October 26, 2024 14:13
@dragonJACson dragonJACson marked this pull request as ready for review October 26, 2024 14:16
@dragonJACson dragonJACson force-pushed the dev/cm branch 2 times, most recently from 02dc516 to fa36073 Compare October 26, 2024 14:43
dragonJACson
dragonJACson commented Nov 3, 2024
View reviewed changes
src/cm/communication_manager.rs Outdated
if !context_ptr.is_null() {
// Whenever we consumed the raw pointer of [`Weak`], we should create a new one
// and store in in context for next time of calling.
let cm = Weak::from_raw(context_ptr).upgrade().unwrap();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using loom here for testing upgrade failure

@dragonJACson dragonJACson force-pushed the dev/cm branch 2 times, most recently from d768081 to b19c5d2 Compare November 4, 2024 16:07
@dragonJACson dragonJACson force-pushed the dev/cm branch 7 times, most recently from cdf6cd8 to 2c510a7 Compare November 14, 2024 15:11
@dragonJACson dragonJACson force-pushed the dev/cm branch 5 times, most recently from 5082afe to 3589988 Compare November 24, 2024 13:45
FujiZ
FujiZ reviewed Nov 24, 2024
View reviewed changes
src/cm/communication_manager.rs Outdated Show resolved Hide resolved
src/cm/communication_manager.rs Outdated Show resolved Hide resolved
src/cm/communication_manager.rs Show resolved Hide resolved
src/cm/communication_manager.rs Outdated Show resolved Hide resolved
src/cm/communication_manager.rs Outdated Show resolved Hide resolved
src/cm/communication_manager.rs Outdated Show resolved Hide resolved
src/cm/communication_manager.rs Outdated Show resolved Hide resolved
src/cm/communication_manager.rs Outdated Show resolved Hide resolved
src/cm/communication_manager.rs Outdated Show resolved Hide resolved
src/cm/communication_manager.rs Outdated Show resolved Hide resolved
@dragonJACson dragonJACson force-pushed the dev/cm branch 4 times, most recently from 4608e61 to 6c60451 Compare December 1, 2024 15:07
@dragonJACson dragonJACson force-pushed the dev/cm branch 5 times, most recently from 82b8656 to fc21d42 Compare December 3, 2024 15:04
FujiZ
FujiZ reviewed Dec 10, 2024
View reviewed changes
src/cm/communication_manager.rs Outdated Show resolved Hide resolved
src/cm/communication_manager.rs Show resolved Hide resolved
src/cm/communication_manager.rs Outdated Show resolved Hide resolved
@dragonJACson dragonJACson merged commit f2a11d6 into main Dec 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FujiZ FujiZ FujiZ approved these changes

Assignees

@dragonJACson dragonJACson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dragonJACson @FujiZ