fix: remove use of JSON LD from CQL JSON parsing #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… numeric and string comparisons. e.g. FILTER(?var = 2000) will match on 2000, "2000"^^xsd:decimal etc. whereas VALUES ?var { 2000 } will only match on the exact same value. Use a triple pattern match for "=" filtering where the RHS operand is a URI. This should be more performant.
lalewis1
approved these changes
Jan 7, 2025
|
Unfortunately the code touches a lot of places. In short, previously the CQL JSON was converted to JSON LD by injecting a JSON LD context, in order to convert "non semantic" JSON (CQL JSON) into RDF. The thinking was this would make interpreting/using the CQL JSON easier in Prez; in some ways it does, but ultimately it created more issues than it solved, so this change removes the injection of the JSON LD context. |
…ofile in order to support geometries that are specified on named node sequence paths (rather than the common specification of geometries using blank nodes).
…l-remove-context # Conflicts: # poetry.lock
|
🎉 This PR is included in version 4.2.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the use of JSON LD with CQL JSON to simplify parsing/processing of CQL JSON.
In order to do this, CQL JSON properties that begin with "http" are interpreted as URIs. This is a reasonable but not foolproof assumption that may need revision.
Tests that previously only passed with Fuseki now work with the inclusion of GeoSPARQL support in Oxigraph and have been uncommented.