-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update helm charts for Sentry configuration #311
base: main
Are you sure you want to change the base?
Conversation
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
c520c7a
to
2dcd892
Compare
2dcd892
to
7562af7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Nice work! One small thing is that would it be more efficient to replace package definitions like:
packages: "org.radarbase.oura,org.radarbase.connect"
to more simple
packages: "org.radarbase"
? So to basically trace from org.radarbase.*
?
# -- Set to true, if stack trace should be enabled | ||
enabled: true | ||
# -- Comma-separated list of package prefixes to be included in the stacktrace | ||
packages: "org.radarbase.appconfig,org.radarbase.lang,comparisons" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this package string correct? The comparisons
part looks strange to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes,this is the one that is packaged under comparisons:
radar-expression-lang/src/main/kotlin/comparisons/Library.kt
If not needed, I can remove it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ewelinagr Did you perhaps miss this comment?
Yes, it could be simplified to |
b844fe6
to
c395737
Compare
c395737
to
bac7b94
Compare
2422db2
to
9bb45b5
Compare
Implements RB-152
Some of the components have been enhanced with Sentry monitoring. This PR: