Add upload config to appserver chart #271
Conversation
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
pvannierop
force-pushed
the
feature/appserver-upload-config
branch
2 times, most recently
from
acd2ee1 to
c5ae7a6
Compare
pvannierop
force-pushed
the
feature/appserver-upload-config
branch
from
c5ae7a6 to
e104604
Compare
| # -- Secret key of the S3 storage | ||
| secret_key: secret | ||
| path: | ||
| # -- Prefix for the path in the storage; will become <bucket>/<prefix>/<project>/<subject>/<topic> |
There was a problem hiding this comment.
This line is a bit unclear to me.
| # Settings for file storage | ||
| storage: | ||
| # -- Type of storage to use for file upload (s3) | ||
| type: s3 |
There was a problem hiding this comment.
What other storage types are supported?
There was a problem hiding this comment.
No other, only s3 at this time.
| # -- Type of storage to use for file upload (s3) | ||
| type: s3 | ||
| # -- Internal url to storage | ||
| url: http://minio-headless:9000 |
There was a problem hiding this comment.
I think region should also be configured.
https://github.com/RADAR-base/radar-helm-charts/blob/main/charts/radar-s3-connector/values.yaml#L186C1-L187C10
There was a problem hiding this comment.
It is not yet implemented in the application. Should I add it to the helm chart already? Indeed region is missing and this explains the problems using AWS S3.
This PR adds helm chart configuration for the new file upload endpoint of appserver.