Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.5.2 #123

Merged
merged 26 commits into from
May 8, 2024
Merged

Release 0.5.2 #123

merged 26 commits into from
May 8, 2024

Conversation

mpgxvii
Copy link
Member

@mpgxvii mpgxvii commented Apr 17, 2024

mpgxvii and others added 22 commits March 4, 2024 17:07
Fix processing of sleep efficiency in FitbitSleepAvroConverter
Update routes to limit range to 30 days
Fix breathing and skin temperature convertors
Add Fitbit spo2 route and converter
Bump radar-schemas to latest version
@Bdegraaf1234
Copy link
Contributor

Probably good to add a working codeql configuration, snyk workflow and perform security updates?

I will make PRs. If there is a hurry you can make this release first but it shouldn't take long

@mpgxvii
Copy link
Member Author

mpgxvii commented Apr 18, 2024

Probably good to add a working codeql configuration, snyk workflow and perform security updates?

I will make PRs. If there is a hurry you can make this release first but it shouldn't take long

@Bdegraaf1234 Yes indeed would be good to have CodeQL working. Yes I can wait before making the release. Thank you!

@Bdegraaf1234
Copy link
Contributor

@mpgxvii Ready when you are ;)

#124 <-- Ready to merge
#125 <-- Needs snyk token in the repo secrets
#126 <-- Should be merged after #125

@Bdegraaf1234
Copy link
Contributor

Why did the CodeQl action not run? 😆

Also maybe nice to rebase onto dev rather than merge to prevent unneeded merge commits

@mpgxvii
Copy link
Member Author

mpgxvii commented Apr 18, 2024

Why did the CodeQl action not run? 😆

Also maybe nice to rebase onto dev rather than merge to prevent unneeded merge commits

@Bdegraaf1234 Ah yes will do. It didn't run because the branch was main instead of master. Updated it now on this release branch.

@Bdegraaf1234
Copy link
Contributor

Bdegraaf1234 commented Apr 22, 2024

I think this one is ready to go after rebasing the security updates #126 ^^

Copy link
Contributor

@Bdegraaf1234 Bdegraaf1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpgxvii mpgxvii merged commit 361ae2b into master May 8, 2024
12 checks passed
@mpgxvii mpgxvii deleted the release-0.5.2 branch May 8, 2024 11:43
@mpgxvii mpgxvii restored the release-0.5.2 branch May 8, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants