Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix default password for minio." #339

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bin/generate-secrets
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,8 @@ nginx_auth_password=$(generate_secret)
secret="thehyve:$(echo $nginx_auth_password | openssl passwd -apr1 -stdin)" insert_secret ".kube_prometheus_stack.nginx_auth"
comment="username: thehyve, password: $nginx_auth_password" yq -i ".kube_prometheus_stack.nginx_auth line_comment |= strenv(comment)" etc/secrets.yaml

# Generate secrets for all remaining fields with value 'secret' or 'secret-secret' (if the component has a min length requirement).
replacements=$(yq e '.. | select(. == "secret" or "secret-secret") | [(path | "."+join("."))] | join(" ")' etc/secrets.yaml);
# Generate secrets for all remaining fields with value 'secret'.
replacements=$(yq e '.. | select(. == "secret") | [(path | "."+join("."))] | join(" ")' etc/secrets.yaml);
for key in $replacements; do
insert_secret $key
done
7 changes: 3 additions & 4 deletions etc/base-secrets.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -147,10 +147,9 @@ radar_integration:

# --------------------------------------------------------- 20-s3-connector.yaml ---------------------------------------------------------
# The access keys and secret keys of object storage services should match.
# If AWS S3 is used as a storage medium instead of minio, then enter the AWS-provided secrets here.
# For minio the secrets must consist of at least 8 characters.
s3_access_key: secret-secret
s3_secret_key: secret-secret
# If AWS S3 is used as a storage medium instead of minio, then fill in those.
s3_access_key: secret
s3_secret_key: secret

# --------------------------------------------------------- 20-upload.yaml ---------------------------------------------------------
radar_upload_postgres_password: secret
Expand Down
Loading