Fix default password for minio. #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvannierop
requested changes
Dec 11, 2024
|
Minio shouldn't have a default password and it should be auto-generated. How does this issue happen? |
Minio won't start if the password length is less than 9 characters.
ewelinagr
force-pushed
the
fix-default-minio-pass
branch
from
4414e84 to
c0c8a57
Compare
pvannierop
approved these changes
Dec 13, 2024
|
@pvannierop the CI test of last commit on the release branch was passing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MinIO won't start if the password length is less than 9 characters.
In the development setup there was a default password for MinIO, which does not meet the requirements (at least 8 characters). With that setup Minio hangs on "Adding local minio host to 'mc' configuration. " and won't start.
Note added by @pvannierop
Being able to use unmodified passwords is only relevant for development deployments that run wit non-randomized passwords. Hence, this change does not affect production envrionments.