New: functions underlaying paper "A novel tool to access crosstalk in luminescence detection" Anna-Maartje de Boer, Luc Steinbuch

[LucSteinbuch]

See email

[mcol]

Thanks Luc! I've launched our continuous integration tests, but I've realised that they will probably fail. What's required is to run devtools::document() from your repository and commit the changes to NAMESPACE and and the documentation files under the man directory (only those concerning your new functions, you should ignore the rest).

Are you comfortable with that? Otherwise I'll make those changes myself if I'm allowed to push to your branch.

[LucSteinbuch]

Hi Marco, Thanks for your message! If you want to make those changes: please go ahead! And let me know if I need to do any setting on github, to "allow" you to do anything. Please note that Anna-Maartje as well as myself are new to forking and pushing in git, so we might need some guidance how to get things done. Bye, Luc Van: Marco Colombo ***@***.***> Verzonden: woensdag 5 februari 2025 14:30 Aan: R-Lum/Luminescence ***@***.***> CC: Steinbuch, Luc ***@***.***>; Author ***@***.***> Onderwerp: Re: [R-Lum/Luminescence] New: functions underlaying paper "A novel tool to access crosstalk in luminescence detection" Anna-Maartje de Boer, Luc Steinbuch (PR #560) Thanks Luc! I've launched our continuous integration tests, but I've realised that they will probably fail. What's required is to run devtools::document() from your repository and commit the changes to NAMESPACE and and the documentation files under the man directory (only those concerning your new functions, you should ignore the rest). Are you comfortable with that? Otherwise I'll make those changes myself if I'm allowed to push to your branch. - Reply to this email directly, view it on GitHub<#560 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AFQHYOBGL5HOSXLOVXQDFCL2OIG5NAVCNFSM6AAAAABWRBATFCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMZWHA2TSNBWHE>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[RLumSK]

@mcol: You have maintainer rights, so you should be able to make those changes.

[mcol]

I've made the minimum number of changes to make the package compile with the new functions, let's see if we remain green or if I missed something. Next I'll start adding some tests.

[mcol]

OK, I've added tests to cover the new functions (only a few lines are still missing from complete coverage). As far as I'm concerned, this is ready to be merged on master. We'll iterate further from there, I'll follow up by email.

@RLumSK If you are happy too, please do the merge as Luc's commit is not signed.

@LucSteinbuch Next time (we really hope it will be soon!) we'll ask you to make sure that your commits are verified according to this doc: https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification (I forgot that we have this requirement).

[RLumSK]

I suggest merging the calc_MoransI_xxx() functions into one calc_MoransI() that then has an option "method" to tap into the different approaches. This would declutter a little bit the documentation and number of exported functions.

Perhaps the best approach is to branch out this functions into a separate file called calc_MoransI.R otherwise it will be hard to find the functions and it somewhat breaks the logic how functions are implemented in the package. The rules to apply here:

• Each exported functions has its own .R file.
• If helper functions are required they can go either into the same file with a name that is preceded by an . (e.g., .get_something <- function ...) or we safe them in the internals_RLum.R file.
• Exceptions are always possible, however, they should be truly justified.

[mcol]

I've applied some of the changes suggested. I think we should liaise with @LucSteinbuch as per changes to the exported functions, and that's what I meant to iterate on once an initial version is merged.

[mcol]

I've renamed some of the function arguments as follows:

• renamed bo_return_inbetween_numbers to return_intermediate_values
• removed all the bo_ prefixes

[mcol]

OK, all the changes we discussed are now implemented, so I think this can now be merged.