Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update URL paths to use dynamic menu structure via useContent hook & also updated the package.json files dev scipts that caused error on windows machine while setting up project locally ! #7201

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

iitzIrFan
Copy link

@iitzIrFan iitzIrFan commented Dec 27, 2024

What is it?

  • Feature / enhancement
  • Bug

Description

  1. Refactored URL Groups :-

    • Replaced hard-coded lists (QWIK_GROUP, QWIK_ADVANCED_GROUP, QWIKCITY_GROUP, and QWIKCITY_ADVANCED_GROUP) with a dynamic menu structure utilizing the useContent hook.
    • This refactor improves code maintainability and simplifies adding or updating paths in the future.
  2. Fixed Local Setup Errors :-

    • Updated the package.json files to resolve errors encountered while setting up the project locally.
    • This ensures a smoother onboarding experience for developers working on the repository.

Related Issue :-

#6802

Checklist

…also updated the package.json files dev scipts that caused error on windows machine while setting up project locally !
@iitzIrFan iitzIrFan requested review from a team as code owners December 27, 2024 17:33
Copy link

changeset-bot bot commented Dec 27, 2024

⚠️ No Changeset found

Latest commit: eb65259

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good idea

package.json Show resolved Hide resolved
packages/docs/package.json Outdated Show resolved Hide resolved
packages/docs/src/routes/docs/menu.md Show resolved Hide resolved
packages/docs/src/routes/docs/menu.md Outdated Show resolved Hide resolved
packages/docs/src/routes/docs/menu.md Outdated Show resolved Hide resolved
packages/docs/src/routes/docs/menu.md Outdated Show resolved Hide resolved
@iitzIrFan
Copy link
Author

@wmertens
About my recent commit,
I had updated the package.json as per requested and am working to resolve bug that, causes the error of not running on Windows OS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants