docs(cookbox/theme-management): replaces deprecated tailwind "class" … #7113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…method From the official tailwind docs: "The selector strategy replaced the class strategy in Tailwind CSS v3.4.1." Relevant URL below: https://tailwindcss.com/docs/dark-mode All other behavior has been maintained.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description
TLDR: Fixes deprecated method.
This is a small change. At some point, the 'class' strategy was replaced by the 'selector' strategy.
Despite the small code change, I'm marking this as a draft for one big reason:
If that gets fixed, this should be an easy merge. Everything works as it did before (test repo if curious).
I plan on making a new PR after this as I want to improve the behavior of the guide. Mainly, the current guide doesn't respect the user's default theme.
Checklist