Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): throw when importing twice #7109

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix(core): throw when importing twice #7109

wants to merge 6 commits into from

Conversation

wmertens
Copy link
Member

@wmertens wmertens commented Nov 28, 2024

this should make it easier to detect build misconfigurations

Closes #3883

@wmertens wmertens requested a review from a team as a code owner November 28, 2024 12:14
@wmertens wmertens enabled auto-merge November 28, 2024 12:14
Copy link

changeset-bot bot commented Nov 28, 2024

🦋 Changeset detected

Latest commit: 351bf38

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@builder.io/qwik Minor
eslint-plugin-qwik Minor
@builder.io/qwik-city Minor
create-qwik Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@wmertens wmertens requested a review from a team as a code owner November 28, 2024 12:29
@wmertens wmertens force-pushed the warn-duplicate branch 3 times, most recently from 832be23 to 6ba9072 Compare November 28, 2024 12:45
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks great to me @wmertens 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐞] Duplicate implementations of JSXNode Errors in RC, v0.103
3 participants