Skip to content

Commit

Permalink
chore: remove bazel (#334)
Browse files Browse the repository at this point in the history
  • Loading branch information
manucorporat authored Mar 28, 2022
1 parent a29e3a8 commit eb26f6f
Show file tree
Hide file tree
Showing 25 changed files with 1,018 additions and 1,761 deletions.
7 changes: 0 additions & 7 deletions .bazel_fix_commands.json

This file was deleted.

6 changes: 0 additions & 6 deletions .bazelignore

This file was deleted.

90 changes: 0 additions & 90 deletions .bazelrc

This file was deleted.

1 change: 0 additions & 1 deletion .bazelversion

This file was deleted.

1 change: 0 additions & 1 deletion .dockerignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
.vscode
dist
dist-dev
bazel-*
node_modules
tsc-out
external
Expand Down
1 change: 0 additions & 1 deletion .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
.vscode
dist
dist-dev
bazel-*
node_modules
tsc-out
external
Expand Down
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
.vscode/settings.json
dist
dist-dev
bazel-*
node_modules
tsc-out
external
Expand Down
5 changes: 0 additions & 5 deletions .prettierignore
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,6 @@
.vscode/settings.json
.history
.yarn
bazel-*
bazel-bin
bazel-out
bazel-qwik
bazel-testlogs
dist
dist-dev
etc
Expand Down
56 changes: 0 additions & 56 deletions BUILD.bazel

This file was deleted.

26 changes: 0 additions & 26 deletions DEVELOPER.md
Original file line number Diff line number Diff line change
Expand Up @@ -89,32 +89,6 @@ to [@builder.io/qwik](https://www.npmjs.com/package/@builder.io/qwik).

- [Starter CLI](https://github.com/BuilderIO/qwik/blob/main/starters/README.md)

## Bazel

Bazel is currently used for further testing and builds between internal repos. However, it is not required for local development and contribution to Qwik.

### Setting up the Bazel environment

Best way to run `bazel` is with [`bazelisk`](https://github.com/bazelbuild/bazelisk) which will automatically download and execute the right version of `bazel`.

_preferred way_

```
brew install bazelisk
```

or

```
npm install -g @bazel/bazelisk
```

`Bazel` will invoke `Yarn` and manage all dependencies.

### `bazel` vs `ibazel`

The difference between `bazel` and `ibazel` is that `ibazel` will re-invoke `bazel` if any relevant files change. This is useful for constantly updating the server and or tests as they are being developed. All commands are listed as `bazel`, but can be replaced for `ibazel` as needed.

## Pre-submit hooks

The project has pre-submit hooks, which ensure that your code is correctly formatted. You can run them manually like so:
Expand Down
24 changes: 0 additions & 24 deletions WORKSPACE

This file was deleted.

5 changes: 0 additions & 5 deletions docs/.prettierignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,6 @@
.vscode/settings.json
.history
.yarn
bazel-*
bazel-bin
bazel-out
bazel-qwik
bazel-testlogs
dist
dist-dev
etc
Expand Down
1 change: 0 additions & 1 deletion docs/qwest/src/vite/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,6 @@ export const IGNORE_EXT: { [key: string]: boolean } = {
'.toml': true,
'.lock': true,
'.log': true,
'.bazel': true,
'.bzl': true,
};

Expand Down
2 changes: 1 addition & 1 deletion eslint-rules/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "eslint-plugin-qwik",
"version": "0.0.18-6",
"version": "0.0.18-7",
"description": "An Open-Source sub-framework designed with a focus on server-side-rendering, lazy-loading, and styling/animation.",
"main": "index.js",
"author": "",
Expand Down
5 changes: 0 additions & 5 deletions notes.md

This file was deleted.

40 changes: 14 additions & 26 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@builder.io/qwik",
"version": "0.0.18-6",
"version": "0.0.18-7",
"description": "An Open-Source sub-framework designed with a focus on server-side-rendering, lazy-loading, and styling/animation.",
"scripts": {
"build": "node scripts --tsc --build --api --eslint --platform-binding --wasm",
Expand Down Expand Up @@ -35,29 +35,19 @@
"lint.prettier": "prettier --check .",
"prettier.fix": "prettier --write .",
"fmt": "npm run prettier.fix",
"patch-m1": "npm run patch-m1-bazel && npm run patch-m1-ibazel && npm run patch-m1-buildifier",
"patch-m1-bazel": "echo Patching Bazel for Apple M1 architecture compatibility && ln -fs ./bazelisk-darwin_amd64 node_modules/@bazel/bazelisk/bazelisk-darwin_arm64",
"patch-m1-ibazel": "echo Patching iBazel for Apple M1 architecture compatibility && sed -i .bak \"s/'x64' : 'amd64',\\$/'x64' : 'amd64', 'arm64' : 'amd64',/\" ./node_modules/@bazel/ibazel/index.js",
"patch-m1-buildifier": "echo Patching Buildifier for Apple M1 architecture compatibility && sed -i .bak \"s/'x64' : 'amd64',\\$/'x64' : 'amd64', 'arm64' : 'amd64',/\" ./node_modules/@bazel/buildifier/buildifier.js",
"bazel:format": "find . -type f \\( -name \"*.bzl\" -or -name WORKSPACE -or -name BUILD -or -name BUILD.bazel \\) ! -path \"*/node_modules/*\" | xargs buildifier --warnings=attr-cfg,attr-license,attr-non-empty,attr-output-default,attr-single-file,constant-glob,ctx-actions,ctx-args,depset-iteration,depset-union,dict-concatenation,duplicated-name,filetype,git-repository,http-archive,integer-division,load,load-on-top,native-build,native-package,out-of-order-load,output-group,package-name,package-on-top,positional-args,redefined-variable,repository-name,same-origin-load,string-iteration,unsorted-dict-items,unused-variable",
"bazel:lint": "npm run bazel:format -- --mode=check --lint=warn",
"bazel:lint-fix": "npm run bazel:format -- --mode=fix --lint=fix",
"link.dist": "cd dist-dev/@builder.io-qwik && npm link",
"qwik-save-artifacts": "node -r esbuild-register ./scripts/qwik-save-artifacts.ts",
"preinstall": "node scripts/tools/preinstall-script.js"
},
"devDependencies": {
"@bazel/bazelisk": "1.7.5",
"@bazel/ibazel": "0.15.10",
"@bazel/typescript": "4.6.1",
"@builder.io/partytown": "0.5.0",
"@builder.io/partytown": "0.5.1",
"@builder.io/qwik-dom": "2.1.14",
"@microsoft/api-extractor": "7.19.4",
"@napi-rs/cli": "2.4.5",
"@microsoft/api-extractor": "7.19.5",
"@napi-rs/cli": "2.5.0",
"@napi-rs/triples": "1.1.0",
"@node-rs/helper": "1.3.3",
"@octokit/action": "^3.18.0",
"@playwright/test": "1.19.2",
"@playwright/test": "1.20.1",
"@types/cross-spawn": "6.0.2",
"@types/eslint": "^8.4.1",
"@types/express": "4.17.13",
Expand All @@ -68,13 +58,13 @@
"@types/prompts": "2.0.14",
"@types/semver": "^7.3.9",
"@types/source-map-support": "0.5.4",
"@typescript-eslint/eslint-plugin": "5.14.0",
"@typescript-eslint/parser": "5.14.0",
"@typescript-eslint/eslint-plugin": "5.16.0",
"@typescript-eslint/parser": "5.16.0",
"concurrently": "7.0.0",
"cross-spawn": "7.0.3",
"esbuild": "0.14.25",
"esbuild": "0.14.28",
"esbuild-register": "3.3.2",
"eslint": "^8.12.0",
"eslint": "8.12.0",
"eslint-plugin-no-only-tests": "2.6.0",
"eslint-plugin-qwik": "0.0.18-dev123",
"execa": "6.1.0",
Expand All @@ -83,18 +73,18 @@
"husky": "7.0.4",
"jest": "27.5.1",
"kleur": "4.1.4",
"lint-staged": "12.3.5",
"lint-staged": "12.3.7",
"mri": "1.2.0",
"path-browserify": "1.0.1",
"prettier": "2.5.1",
"prettier": "2.6.1",
"prompts": "2.4.2",
"rollup": "2.70.0",
"rollup": "2.70.1",
"semver": "7.3.5",
"source-map-support": "0.5.21",
"terser": "5.12.0",
"terser": "5.12.1",
"todomvc-app-css": "2.4.2",
"todomvc-common": "1.0.5",
"ts-jest": "27.1.3",
"ts-jest": "27.1.4",
"typescript": "4.5.5",
"vite": "2.8.6",
"wasm-pack": "0.10.2"
Expand Down Expand Up @@ -220,7 +210,6 @@
"<rootDir>/src/napi/",
"<rootDir>/src/optimizer/",
"<rootDir>/src/wasm/",
"<rootDir>/bazel-out",
"<rootDir>/dist",
"<rootDir>/dist-dev",
"<rootDir>/integration",
Expand All @@ -234,7 +223,6 @@
"<rootDir>/.github/",
"<rootDir>/.husky/",
"<rootDir>/.vscode/",
"<rootDir>/bazel-out",
"<rootDir>/bin/",
"<rootDir>/src/cli/",
"<rootDir>/src/napi/",
Expand Down
Loading

0 comments on commit eb26f6f

Please sign in to comment.