Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Classes Public For Extra Loaders Through Plugins #466

Closed
wants to merge 2 commits into from
Closed

Make Classes Public For Extra Loaders Through Plugins #466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88c72bf
Made ModDependencyImpl public
coolGi69 Jan 3, 2025
854e7c0
Made constructors for PluginIconImpl public
coolGi69 Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/main/java/org/quiltmc/loader/impl/gui/PluginIconImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,12 @@ public final class PluginIconImpl extends QuiltGuiSyncBase implements QuiltLoade
final IconType icon;
final IconType[] subIcons = new IconType[4];

PluginIconImpl() {
public PluginIconImpl() {
super(null);
this.icon = new BlankIcon();
}

PluginIconImpl(String path) {
public PluginIconImpl(String path) {
super(null);
this.icon = new BuiltinIcon(path);
}
Expand All @@ -61,7 +61,7 @@ public final class PluginIconImpl extends QuiltGuiSyncBase implements QuiltLoade
}

/** @param images Array of images of different sizes, to be chosen by the UI. */
PluginIconImpl(byte[][] images) {
public PluginIconImpl(byte[][] images) {
super(null);
this.icon = new UploadedIcon(images);
}
Expand Down
8 changes: 4 additions & 4 deletions src/main/java/org/quiltmc/loader/impl/metadata/qmj/ModDependencyImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
import org.quiltmc.loader.impl.util.QuiltLoaderInternalType;

@QuiltLoaderInternal(QuiltLoaderInternalType.LEGACY_EXPOSED)
final class ModDependencyImpl {
public final class ModDependencyImpl {
ModDependencyImpl() {
}

Expand Down Expand Up @@ -103,7 +103,7 @@ static final class AllImpl extends CollectionImpl implements ModDependency.All
}
}

static final class OnlyImpl implements ModDependency.Only {
public static final class OnlyImpl implements ModDependency.Only {
private final String location;
private final ModDependencyIdentifier id;
private final VersionRange range;
Expand All @@ -114,10 +114,10 @@ static final class OnlyImpl implements ModDependency.Only {
/**
* Creates a ModDependency that matches any version of a specific mod id.
*/
OnlyImpl(String location, ModDependencyIdentifier id) {
public OnlyImpl(String location, ModDependencyIdentifier id) {
this(location, id, VersionRange.ANY, "", false, null);
}
OnlyImpl(String location, ModDependencyIdentifier id, VersionRange range, @Nullable String reason, boolean optional, @Nullable ModDependency unless) {
public OnlyImpl(String location, ModDependencyIdentifier id, VersionRange range, @Nullable String reason, boolean optional, @Nullable ModDependency unless) {
// We need to have at least one constraint
if (range.isEmpty()) {
throw new IllegalArgumentException("A ModDependency must have at least one constraint");
Expand Down