-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync with FLK 1.12.3, target MC 1.21 #100
Conversation
Converting this to a draft and updating FLK and KT since I had already done that before realising this code still depends on 1.20.4's QSL. |
Requires testing of the bundling of FLK I did but otherwise should be good to go. Oh and once that's tested I can remove the language adapter code from qkl core instead of just removing the reference. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you are defaulting to FLK for the language provider and just keeping the api?
Yeah that's the plan going forward, core would effectively be gone unless we want to bundle more libraries in the future. |
I believe this PR is ready to be merged, please also see and maybe adjust a little https://discord.com/channels/817576132726620200/1103987526349361192/1294387464848408757. |
Superscedes #98, original PR message will be embeded below...