Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add improved side panel selector and clean up gui #23

Merged
merged 53 commits into from
Jan 6, 2023
Merged

add improved side panel selector and clean up gui #23

merged 53 commits into from
Jan 6, 2023

Conversation

ix0rai
Copy link
Member

@ix0rai ix0rai commented Dec 29, 2022 •
edited
Loading

this pr implements a better selector for side panels and improves a lot of gui code
inspired by, and steals code from, FabricMC/Enigma#420
image

changelog (incomplete):

  • add side panel selector
  • add translation for "send message" button in multiplayer chat

todo:

  • bug: structure panel flashes for a second when a new class is opened
  • bug: panels often forget their states when hiding and showing
  • bug: pressed side button does not always perfectly reflect selected side panel
  • feature: add little "enigma is offline" message to multiplayer windows when enigma is offline
  • feature: consistent text box size in "users" panel
  • feature: make it less ugly
  • feature: title bar above each panel to indicate what's open
  • change: make the whole registration system more robust
  • change: find a better solution than saiko's insane jlayer rotation code

@ix0rai ix0rai added the enhancement New feature or request label Dec 29, 2022
IotaBread
IotaBread reviewed Dec 29, 2022
View reviewed changes
Copy link
Member

@IotaBread IotaBread left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick review, gonna check everything once the pr is done

enigma-swing/src/main/java/cuchaz/enigma/gui/config/UiConfig.java Outdated Show resolved Hide resolved
enigma-swing/src/main/java/cuchaz/enigma/gui/panels/right/AbstractInheritanceTree.java Outdated Show resolved Hide resolved
@ix0rai ix0rai mentioned this pull request Dec 30, 2022
Closed
@ix0rai
fixes
2e1cc5b 
- fix flashing structure panel
- fix calls panel opening with classes
- configure right panel on opening
@ix0rai
better consistency in UsersPanel
53e34ae
@ix0rai
Merge branch 'QuiltMC:master' into different-side-panels
3a84fe8
@ix0rai ix0rai requested a review from IotaBread January 3, 2023 21:23
IotaBread
IotaBread reviewed Jan 4, 2023
View reviewed changes
Copy link
Member

@IotaBread IotaBread left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nitpicking

enigma-swing/src/main/java/cuchaz/enigma/gui/panels/right/RightPanel.java Show resolved Hide resolved
enigma-swing/src/main/java/cuchaz/enigma/gui/panels/right/StructurePanel.java Show resolved Hide resolved
enigma-swing/src/main/java/cuchaz/enigma/gui/panels/right/RightAngleLayerUI.java Show resolved Hide resolved
enigma-swing/src/main/java/cuchaz/enigma/gui/panels/right/MultiplayerPanel.java Outdated Show resolved Hide resolved
enigma-swing/src/main/java/cuchaz/enigma/gui/panels/right/MultiplayerPanel.java Outdated Show resolved Hide resolved
@ix0rai ix0rai requested a review from IotaBread January 5, 2023 01:00
IotaBread
IotaBread approved these changes Jan 6, 2023
View reviewed changes
Copy link
Member

@IotaBread IotaBread left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! I'll do some testing and it should be good to go

@ix0rai
Copy link
Member Author

ix0rai commented Jan 6, 2023

definitely not kicking my feet excitedly right now

@IotaBread IotaBread merged commit eb15b89 into QuiltMC:master Jan 6, 2023
@ix0rai ix0rai deleted the different-side-panels branch January 6, 2023 03:49
@ix0rai ix0rai mentioned this pull request Jan 14, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2xsaiko 2xsaiko 2xsaiko left review comments

@IotaBread IotaBread IotaBread approved these changes

@OroArmor OroArmor OroArmor approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ix0rai @2xsaiko @OroArmor @IotaBread