Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to render the popup portrait on a dedicated page. #136

Conversation

HaudinFlorence
Copy link
Member

@HaudinFlorence HaudinFlorence commented Aug 22, 2024

Try to render the popup portrait on a dedicated page.
This PR fixes #129.

@HaudinFlorence HaudinFlorence force-pushed the open_the_popup_portrait_on_a_specific_page branch from 7e7d2a7 to c3f18c7 Compare August 22, 2024 13:07
@HaudinFlorence HaudinFlorence force-pushed the open_the_popup_portrait_on_a_specific_page branch 12 times, most recently from 9ce18b3 to 1344580 Compare August 29, 2024 07:38
Update static.yml and docusaurus.config.ts files.
@HaudinFlorence HaudinFlorence force-pushed the open_the_popup_portrait_on_a_specific_page branch from 1344580 to 97a3ec2 Compare August 29, 2024 10:13
@HaudinFlorence HaudinFlorence reopened this Sep 3, 2024
Copy link

vercel bot commented Sep 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
quantstack-github-io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 3:55pm

Comment on lines 15 to 19
baseUrl: "/quantstack.github.io/",

// GitHub pages deployment config.
// If you aren't using GitHub pages, you don't need these.
organizationName: "/QuantStack/", // Usually your GitHub org/user name.
organizationName: "/HaudinFlorence/", // Usually your GitHub org/user name.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like these two changes could be reverted?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. I have changed it as well as the baseUrl that has to be "/"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create pages for the popups containing the large portrait cards
2 participants