Changing Overlay Implementation #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinRenou
reviewed
Jun 5, 2024
| _view_module = Unicode(module_name).tag(sync=True) | ||
| _view_module_version = Unicode(module_version).tag(sync=True) | ||
| overlay_type = Unicode().tag(sync=True) | ||
| position = List([0, 0]).tag(sync=True) | ||
|
|
||
| class ImageOverlay (BaseOverlay): | ||
| _view_name = Unicode('ImageOverlayView').tag(sync=True) | ||
| _model_name = Unicode('ImageOverlayModel').tag(sync=True) | ||
|
|
||
| overlay_type = Unicode('image').tag(sync=True) |
There was a problem hiding this comment.
It seems we don't need the overlay_type anymore
Comment on lines
+40
to
+41
| this.element = document.createElement('img'); | ||
| super.render(); |
There was a problem hiding this comment.
That works, but the rule should be to always call super first.
I am actually surprised TypeScript is not complaining here.
The problem is that doing so would break your widget because this.element would not be defined when creating the overlay.
One approach could be to define an abstract createElement method in BaseOverlayView, and all subclasses would need to provide the implementation., then you can call createElement in your BaseOverlayView's createOverlay method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.