Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Controls + Make BaseOverlayView abstract #10

Merged
merged 11 commits into from
Jun 11, 2024
Merged

Implement Controls + Make BaseOverlayView abstract #10

merged 11 commits into from
Jun 11, 2024

Conversation

Nour-Cheour10
Copy link
Contributor

No description provided.

martinRenou
martinRenou reviewed Jun 11, 2024
View reviewed changes
ipyopenlayers/example.py Outdated Show resolved Hide resolved
src/basecontrol.ts Outdated Show resolved Hide resolved
src/imageoverlay.ts Outdated Show resolved Hide resolved
src/fullscreen.ts Outdated Show resolved Hide resolved
src/mouseposition.ts Outdated Show resolved Hide resolved
src/scaleline.ts Outdated Show resolved Hide resolved
src/tilelayer.ts Outdated Show resolved Hide resolved
src/zoomslider.ts Outdated Show resolved Hide resolved
@Nour-Cheour10 Nour-Cheour10 reopened this Jun 11, 2024
martinRenou
martinRenou requested changes Jun 11, 2024
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I just have one comment, otherwiser I think it's good!

ipyopenlayers/example.py Outdated Show resolved Hide resolved
@martinRenou martinRenou changed the title Controls features Implement Controls + Make BaseOverlayView abstract Jun 11, 2024
@martinRenou martinRenou merged commit 6fbecfa into QuantStack:main Jun 11, 2024
0 of 6 checks passed
@martinRenou
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinRenou martinRenou martinRenou requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nour-Cheour10 @martinRenou