Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce unrequired live logs for derivatives chains #8458

Conversation

Marinovsky
Copy link
Collaborator

Description

Reduce unrequired logs for derivatives chains (futures and options) by logging once per parent canonical symbol per update procedure. The method Log.Trace() has an optional parameter called overrideMessageFloodProtection that prevents the method to log the same message more than once. Thus, I changed the log messages in LiveMappingEventProvider.GetEvents(), LiveTradingRealTimeHandler.RefreshMarketHours() and LiveTradingRealTimeHandler.RefreshSymbolProperties(), to use the canonical symbol if the security symbol had it.

Related Issue

Closes #8411

Motivation and Context

With this change, less messages will be logged helping the user to focus on the relevant logs

Requires Documentation Change

N/A

How Has This Been Tested?

I tested my changes running the regression algorithm BasicTemplateOptionsAlgorithm on paper-live mode and asserting the unrequired logs were gone.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

Copy link
Collaborator

@jhonabreul jhonabreul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jhonabreul jhonabreul merged commit fcb4ce6 into QuantConnect:master Dec 12, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce unrequired live logs for derivates chain
3 participants