Add alt text to images #13555
Merged
Add alt text to images #13555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Pull Request Test Coverage Report for Build 12679997871Details
💛 - Coveralls |
9 tasks
…erra into BD-add-alt-text
beckykd
requested review from
a team,
nonhermitian,
alexanderivrii,
ShellyGarion,
eggerdj,
wshanks and
jyu00
as code owners
|
One or more of the following people are relevant to this code:
|
Eric-Arellano
previously approved these changes
Dec 18, 2024
Co-authored-by: Eric Arellano <[email protected]>
ElePT
reviewed
Jan 8, 2025
There was a problem hiding this comment.
Thanks for this PR! I think it's a good start, but I wonder if we would like to eventually make it a bit more informative, because the descriptions are still very generic. I suggested a few minor changes on some descriptions (circuit diagram output instead of output), but overall LGTM. Reviewing this PR also gave me the chance to catch a few documentation bugs (#13635)!
qiskit/synthesis/arithmetic/multipliers/hrs_cumulative_multiplier.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Elena Peña Tapia <[email protected]>
ElePT
added
the
stable backport potential
ElePT
added
Changelog: None
mergify bot
pushed a commit
that referenced
this pull request
Jan 9, 2025
* Add alt text to images * Update operation.py * Update parameter.py * Update quantumcircuit.py * try breaking line * Update __init__.py * Update fourier_checking.py * Update graph_state.py * Update grover_operator.py * add more alt text and some missing directives * add nofigs for missing figures * Add more alt text * next set * need different text when there's no code * fix text when no code * more alt text * remove brackets * More alt text and some fixes * Adding more text * more alt text * missing file name * missing blank line * extra blank line * update allowlist * fix spacing * add more alt text * Apply suggestions from code review Co-authored-by: Eric Arellano <[email protected]> * Apply suggestions from code review Co-authored-by: Elena Peña Tapia <[email protected]> --------- Co-authored-by: Eric Arellano <[email protected]> Co-authored-by: Elena Peña Tapia <[email protected]> (cherry picked from commit b872e88) # Conflicts: # qiskit/transpiler/__init__.py # tools/verify_images.py
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 10, 2025
* Add alt text to images (#13555) * Add alt text to images * Update operation.py * Update parameter.py * Update quantumcircuit.py * try breaking line * Update __init__.py * Update fourier_checking.py * Update graph_state.py * Update grover_operator.py * add more alt text and some missing directives * add nofigs for missing figures * Add more alt text * next set * need different text when there's no code * fix text when no code * more alt text * remove brackets * More alt text and some fixes * Adding more text * more alt text * missing file name * missing blank line * extra blank line * update allowlist * fix spacing * add more alt text * Apply suggestions from code review Co-authored-by: Eric Arellano <[email protected]> * Apply suggestions from code review Co-authored-by: Elena Peña Tapia <[email protected]> --------- Co-authored-by: Eric Arellano <[email protected]> Co-authored-by: Elena Peña Tapia <[email protected]> (cherry picked from commit b872e88) # Conflicts: # qiskit/transpiler/__init__.py # tools/verify_images.py * Update qiskit/transpiler/__init__.py --------- Co-authored-by: Rebecca Dimock <[email protected]> Co-authored-by: Elena Peña Tapia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to add alt text to images for accessibility.