Update macOS x86_64 wheel build CI runner to 10.13 (backport #13470) #13550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* Update macOS x86_64 wheel build CI runner to 10.13 Github actions has deprecated their macOS 10.12 CI runner and will be removing it in December, 2024. We were using this macOS runner because our target OS version for intel mac is 10.12. However, with this enviornment being removed by Github we must upgrade to continue running the jobs. This commit does not bump the MACOSX_DEPLOYMENT_TARGET environment variable (which is used to set the target OS version for intel macs) though, because we should test if we can build it compatibility mode from a newer version of macOS. If this fails then we can bump this to 10.13 in a subsequent commit on this PR and add an upgrade release note to document the change. * Fix macOS deployment target config in cibuildwheel Looking at the 1.3.0 release build the build failed during the audit stage checking the shared object file that was built. This was failing because the macOS target version in the binary was 10.12 but the environment variable to override the default target of 10.9 was not getting set properly. We set this in the pyproject.toml but it is getting overridden by the PGO settings via CIBW_ENVIRONMENT in the github actions config. If you look at the recent builds we were publishing 10.9 target wheels on pypi despite documenting we target 10.12. The CI job logs also show that env variable is never being set during the cibuildwheel process. The release of rust 1.83 in the last 24 hrs probably is what changed the output here causing the failure, although rust was supposed to raise it's minimum target to 10.12 in 1.74 [1] something probably changed in the release today which is tripping up the audit now. This PR updates the CI configuration as was done to hotfix the deployment job temporarily during the 1.3.0 release process [2] to ensure we're setting our macOS deployment target correctly on x86_64 macOS builds to 10.12. [1] https://blog.rust-lang.org/2023/09/25/Increasing-Apple-Version-Requirements.html [2] https://github.com/Qiskit/qiskit/actions/runs/12075613320 --------- Co-authored-by: Julien Gacon <[email protected]> (cherry picked from commit 17648eb)
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
github-actions
bot
added
type: qa
Pull Request Test Coverage Report for Build 12261523897Details
💛 - Coveralls |
1ucian0
approved these changes
Dec 11, 2024
|
I removed this from the queue because it seems the wheels were skipped during CI, I'll try re-triggering this job since we want to make sure the wheels are successful 🙂 Edit: wheels are building now -- I don't know if adding the |
|
All wheels are successfully built 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Github actions has deprecated their macOS 10.12 CI runner and will be removing it in December, 2024. We were using this macOS runner because our target OS version for intel mac is 10.12. However, with this enviornment being removed by Github we must upgrade to continue running the jobs.
This commit does not bump the MACOSX_DEPLOYMENT_TARGET environment variable (which is used to set the target OS version for intel macs) though, because we should test if we can build it compatibility mode from a newer version of macOS. If this fails then we can bump this to 10.13 in a subsequent commit on this PR and add an upgrade release note to document the change.
Details and comments
This is an automatic backport of pull request #13470 done by Mergify.