Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix registering global_phase parameters when creating CircuitData (backport #13538) #13541

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 9, 2024

Summary

Fix a series of bugs caused by not correctly registering the parameters in the CircuitDatas parameter table upon creation. This led to the QuantumCircuit.global_phase attribute not being assigned upon calling assign_parameters. Fixes #13534.

Details and comments

I checked for all constructors that take in a global_phase and tried to add tests for each (e.g. pauli_twirl_2q_gates invokes clone_empty_like).


This is an automatic backport of pull request #13538 done by [Mergify](https://mergify.com).

…#13538)

* fix registering global phase params

* add tests and reno

(cherry picked from commit 6f0a176)
@mergify mergify bot requested a review from a team as a code owner December 9, 2024 13:19
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@github-actions github-actions bot added Changelog: Bugfix Include in the "Fixed" section of the changelog Rust This PR or issue is related to Rust code in the repository labels Dec 9, 2024
@github-actions github-actions bot added this to the 1.3.1 milestone Dec 9, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12236498842

Details

  • 16 of 16 (100.0%) changed or added relevant lines in 2 files are covered.
  • 19 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.02%) to 88.902%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/expr.rs 1 94.02%
crates/qasm2/src/lex.rs 6 91.48%
crates/qasm2/src/parse.rs 12 96.23%
Totals Coverage Status
Change from base Build 12184334626: -0.02%
Covered Lines: 79063
Relevant Lines: 88933

💛 - Coveralls

@Cryoris Cryoris added this pull request to the merge queue Dec 9, 2024
Merged via the queue into stable/1.3 with commit daec1e2 Dec 9, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog Rust This PR or issue is related to Rust code in the repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants