Skip to content

Commit

Permalink
[DNM] Retrigger CI build
Browse files Browse the repository at this point in the history
Looking at the 1.3.0 release build the build failed during the audit
stage checking the shared object file that was built. This was failing
because the macOS target version in the binary was 10.12 but the
environment variable to override the default target of 10.9 was not
getting set properly. We set this in the pyproject.toml but it is
getting overridden by the PGO settings via CIBW_ENVIRONMENT in the
github actions config. If you look at the recent builds we were
publishing 10.9 target wheels on pypi despite documenting we target
10.12. The CI job logs also show that env variable is never being
set during the cibuildwheel process.

The release of rust 1.83 in the last 24 hrs probably is what changed
the output here causing the failure, although rust was supposed to
raise it's minimum target to 10.12 in 1.74 [1] something probably
changed in the release today which is tripping up the audit now.

This PR is temporary to retrigger CI with this fix, we can open a real
PR fixing this will be published after the 1.3.0 release is live.

[1] https://blog.rust-lang.org/2023/09/25/Increasing-Apple-Version-Requirements.html
  • Loading branch information
mtreinish committed Nov 28, 2024
1 parent 896d1c8 commit 55359be
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
1 change: 1 addition & 0 deletions .github/workflows/wheels-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ jobs:
cat >>"$GITHUB_ENV" <<EOF
CIBW_BEFORE_BUILD=bash ./tools/build_pgo.sh $PGO_WORK_DIR $PGO_OUT_PATH
CIBW_ENVIRONMENT=RUSTUP_TOOLCHAIN=stable RUSTFLAGS='-Cprofile-use=$PGO_OUT_PATH -Cllvm-args=-pgo-warn-missing-function'
CIBW_ENVIRONMENT_MACOS=MACOSX_DEPLOYMENT_TARGET='10.12' RUSTUP_TOOLCHAIN=stable RUSTFLAGS='-Cprofile-use=$PGO_OUT_PATH -Cllvm-args=-pgo-warn-missing-function'
CIBW_ENVIRONMENT_LINUX=RUSTUP_TOOLCHAIN=stable RUSTFLAGS='-Cprofile-use=$PGO_OUT_PATH -Cllvm-args=-pgo-warn-missing-function' PATH="\$PATH:\$HOME/.cargo/bin" CARGO_NET_GIT_FETCH_WITH_CLI="true"
EOF
env:
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/wheels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@
name: Deploy release artifacts
on:
push:
tags:
- '*'
branches: [ 'retrigger-ci-wheels' ]
jobs:
build-core:
name: Build core
Expand Down

0 comments on commit 55359be

Please sign in to comment.