Check fix clippy lint in test #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Widen acceptable versions of hashbrown * Use conditional compilation to choose more efficient implementation This allows rust 1.70 but gives no perf penalty for 1.75. There may well be another way around CI failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main point of this PR is to try to avoid frequent CI failures due to
ahashincompatibility with rustc 1.70.This removes a clippy lint overrride that does not exist in the rust 1.70 toolchain.
This PR passes local CI with both 1.70 and 1.75.
However, 1.70 fails in GH CI because an attempt is made to install a version of ahash that does not support rust 1.70.
I have not yet discovered why this does not happen locally.
I'll use this PR to push a bunch of commits to try to troubleshoot the CI failure a bit.