Remove unused method implementing From trait #114
Conversation
This was used in an obsolete, experimental, pyo3 interface. Might be needed in the future, but not now. Closes #76
This restriction is not necessary to build these crates. But we want to be compatible with rustc 1.70 for Qiskit compatibility. So we include this restriction on clap version. Let's see if this fixes the CI failure.
In the previous commit, we set the version of clap to 4.4. But in CI, an attempt is still made to install clap 4.5. No idea why. But I was fairly confident that the attempt to fix CI failure would fail somehow. Let's see what fixing the version to 4.4.15 does in CI. I should note that I am building this locally on linux using rust 1.70, which is our desired MSRV. And the version of clap being used is 4.4.15. Why does CI try to install 4.5, even for ubuntu?
|
CI is failing because the an attempt to install clap v 4.5, which does not support MSRV 1.70 is made. This does not happen which I test locally with rustc v 1.70. It should not be failing here for two reasons.
Yet it is failing. Aha: I deleted Cargo.lock in the local build, and now I get a similar failure locally. |
But local CI now fails
|
I used tilde in version specifiers to actually cap versions of clap. I also added However, even if |
This was used in an obsolete, experimental, pyo3 interface. Might be needed in the future, but not now.
Closes #76