Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add requestModelTimeout #54

Merged
merged 2 commits into from
Jan 16, 2024
Merged

add requestModelTimeout #54

merged 2 commits into from
Jan 16, 2024

Conversation

SKITTLE6969
Copy link
Contributor

Description

requestModelTimeout

Checklist

  • I have personally loaded this code into an updated Qbox project and checked all of its functionality.
  • My pull request fits the contribution guidelines & code conventions.

@mafewtm
Copy link
Member

mafewtm commented Dec 27, 2023

Whats the need for this? and whats the need for the config option?

@SKITTLE6969
Copy link
Contributor Author

SKITTLE6969 commented Dec 27, 2023

Whats the need for this? and whats the need for the config option?
just like below for some potato PC users requestModel sometimes breaks because of not having a timeout config option is to adjust the timeout for people who dont know, below is an example
:(
overextended/ox_lib#451

@mafewtm
Copy link
Member

mafewtm commented Dec 27, 2023

Part of the issue with that update was you had to delete the actual resource and put the new ox_lib version in. You couldnt just replace the old files with the new files. The default wait time is 500 as is. I dont see that being an issue or see a need to extend it

@ChatDisabled ChatDisabled merged commit aac892d into Qbox-project:main Jan 16, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants