Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor HSB color functions #606

Merged
merged 2 commits into from
Feb 2, 2025
Merged

Refactor HSB color functions #606

merged 2 commits into from
Feb 2, 2025

Conversation

RhoSigma-QB64
Copy link
Member

  • removed the HSB functions from BASIC level in afterlastline.bm
  • translated the functions to C/C++ level and put into libqb.cpp

@RhoSigma-QB64
Refactor HSB color functions
583c0d6 
- removed the HSB functions from BASIC level in afterlastline.bm
- translated the functions to C/C++ level and put into libqb.cpp
@RhoSigma-QB64 RhoSigma-QB64 added the enhancement New feature or request label Feb 1, 2025
@RhoSigma-QB64 RhoSigma-QB64 self-assigned this Feb 1, 2025
a740g
a740g approved these changes Feb 2, 2025
View reviewed changes
Copy link
Contributor

@a740g a740g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to move these to internal/c/libqb/include/image.h and internal/c/parts/video/image/image.cpp. Both libqb.cpp and qbx.cpp pull in image.h.

@RhoSigma-QB64
Moved stuff
f06961e 
- moved stuff into libqb/graphics.h/.cpp as per suggestion by @a740g
@RhoSigma-QB64 RhoSigma-QB64 merged commit 094748c into main Feb 2, 2025
4 checks passed
@RhoSigma-QB64 RhoSigma-QB64 deleted the hsb-refactoring branch February 2, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a740g a740g a740g approved these changes

@grymmjack grymmjack Awaiting requested review from grymmjack

@mkilgore mkilgore Awaiting requested review from mkilgore

@flukiluke flukiluke Awaiting requested review from flukiluke

@SteveMcNeill SteveMcNeill Awaiting requested review from SteveMcNeill

Assignees

@RhoSigma-QB64 RhoSigma-QB64

Labels
enhancement New feature or request
Projects
Backlog/In Progress
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RhoSigma-QB64 @a740g