Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disables mouse event suppression on macOS when the mouse is hidden and moved #602

Merged
merged 3 commits into from
Jan 25, 2025

Conversation

a740g
Copy link
Contributor

@a740g a740g commented Jan 24, 2025

This PR fixes a bug on macOS where mouse events are suppressed for 0.25 seconds when _MOUSEMOVE is used. The issue is resolved by calling CGAssociateMouseAndMouseCursorPosition(). Note that the event suppression bypass only happens when the mouse is hidden.

Additionally, as discussed on Discord, this PR prevents _FULLPATH$ from throwing an error when an empty string is passed.

@a740g a740g added the bug Something isn't working label Jan 24, 2025
@a740g a740g self-assigned this Jan 24, 2025
Copy link
Member

@RhoSigma-QB64 RhoSigma-QB64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the _FULLPATH$ change, maybe you wanna change this too https://discord.com/channels/975381912350752819/975389657212805160/1329530280155021443 as according to the discussion all supported platforms don't care about double separators, this wouldn't be a breaking change.

@grymmjack
Copy link
Contributor

✅ Tested and working great on this mac:
image

I ran the example you shared in the discord thread ahead of checking out and trying with the PR code and this new code does seem more responsive/fluid.

Both had trackpad intertia - I didn't try with mouse just trackpad.

@a740g
Copy link
Contributor Author

a740g commented Jan 24, 2025

Thanks for the _FULLPATH$ change, maybe you wanna change this too https://discord.com/channels/975381912350752819/975389657212805160/1329530280155021443 as according to the discussion all supported platforms don't care about double separators, this wouldn't be a breaking change.

No problem. Done. I ran some tests and it looks like we are good on all platforms.

@a740g
Copy link
Contributor Author

a740g commented Jan 24, 2025

✅ Tested and working great on this mac: image

I ran the example you shared in the discord thread ahead of checking out and trying with the PR code and this new code does seem more responsive/fluid.

Both had trackpad intertia - I didn't try with mouse just trackpad.

Thank you @grymmjack

@a740g a740g merged commit cae4a85 into QB64-Phoenix-Edition:main Jan 25, 2025
4 checks passed
@a740g a740g deleted the macos-fixes branch January 25, 2025 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants