143 serialization deserialization bug

cobra/model_building/__init__.py

@@ -1,13 +1,13 @@
-from .univariate_selection import compute_univariate_preselection
-from .univariate_selection import get_preselected_predictors
-from .univariate_selection import compute_correlations
-
-from .models import LogisticRegressionModel, LinearRegressionModel
-from .forward_selection import ForwardFeatureSelection
-
-__all__ = ['compute_univariate_preselection',
-           'get_preselected_predictors',
-           'compute_correlations',
-           'LogisticRegressionModel',
-           'LinearRegressionModel',
-           'ForwardFeatureSelection']
+from .univariate_selection import compute_univariate_preselection
+from .univariate_selection import get_preselected_predictors
+from .univariate_selection import compute_correlations
+
+from .models import LogisticRegressionModel, LinearRegressionModel
+from .forward_selection import ForwardFeatureSelection
+
+__all__ = ['compute_univariate_preselection',
+           'get_preselected_predictors',
+           'compute_correlations',
+           'LogisticRegressionModel',
+           'LinearRegressionModel',
+           'ForwardFeatureSelection']

cobra/preprocessing/target_encoder.py

@@ -5,6 +5,7 @@
 from tqdm.auto import tqdm
 from sklearn.base import BaseEstimator
 from sklearn.exceptions import NotFittedError
+import numpy as np
 
 log = logging.getLogger(__name__)
 
@@ -123,7 +124,7 @@ def set_attributes_from_dict(self, params: dict):
                 params["imputation_strategy"] in self.valid_imputation_strategies):
             self.imputation_strategy = params["imputation_strategy"]
 
-        if "_global_mean" in params and type(params["_global_mean"]) == float:
+        if "_global_mean" in params and isinstance(params["_global_mean"], (np.floating, float)):
             self._global_mean = params["_global_mean"]
 
         _mapping = {}

cobra/utils.py

@@ -1,24 +1,24 @@
-import logging
-
-# logger = logging.getLogger(__name__)
-# logger.setLevel(logging.INFO)
-# logger.addHandler(logging.Handler())
-
-
-def clean_predictor_name(predictor_name: str) -> str:
-    """Strip the redundant suffix (e.g. "_enc" or "_bin") off from the end
-    of the predictor name to return a clean version of the predictor
-    """
-    return (
-        predictor_name.replace("_enc", "").replace("_bin", "").replace("_processed", "")
-    )
-
-
-def log_tutorial() -> None:
-    logging.info(
-        """
-    Hi, welcome to Cobra!
-    You can find some tutorials that explain the functioning of cobra on the PythonPredictions GitHub:
-    https://github.com/PythonPredictions/cobra/tree/master/tutorials
-        """
-    )
+import logging
+
+# logger = logging.getLogger(__name__)
+# logger.setLevel(logging.INFO)
+# logger.addHandler(logging.Handler())
+
+
+def clean_predictor_name(predictor_name: str) -> str:
+    """Strip the redundant suffix (e.g. "_enc" or "_bin") off from the end
+    of the predictor name to return a clean version of the predictor
+    """
+    return (
+        predictor_name.replace("_enc", "").replace("_bin", "").replace("_processed", "")
+    )
+
+
+def log_tutorial() -> None:
+    logging.info(
+        """
+    Hi, welcome to Cobra!
+    You can find some tutorials that explain the functioning of cobra on the PythonPredictions GitHub:
+    https://github.com/PythonPredictions/cobra/tree/master/tutorials
+        """
+    )

docs/make.bat

@@ -1,35 +1,35 @@
-@ECHO OFF
-
-pushd %~dp0
-
-REM Command file for Sphinx documentation
-
-if "%SPHINXBUILD%" == "" (
-	set SPHINXBUILD=sphinx-build
-)
-set SOURCEDIR=source
-set BUILDDIR=build
-
-if "%1" == "" goto help
-
-%SPHINXBUILD% >NUL 2>NUL
-if errorlevel 9009 (
-	echo.
-	echo.The 'sphinx-build' command was not found. Make sure you have Sphinx
-	echo.installed, then set the SPHINXBUILD environment variable to point
-	echo.to the full path of the 'sphinx-build' executable. Alternatively you
-	echo.may add the Sphinx directory to PATH.
-	echo.
-	echo.If you don't have Sphinx installed, grab it from
-	echo.https://www.sphinx-doc.org/
-	exit /b 1
-)
-
-%SPHINXBUILD% -M %1 %SOURCEDIR% %BUILDDIR% %SPHINXOPTS% %O%
-goto end
-
-:help
-%SPHINXBUILD% -M help %SOURCEDIR% %BUILDDIR% %SPHINXOPTS% %O%
-
-:end
-popd
+@ECHO OFF
+
+pushd %~dp0
+
+REM Command file for Sphinx documentation
+
+if "%SPHINXBUILD%" == "" (
+	set SPHINXBUILD=sphinx-build
+)
+set SOURCEDIR=source
+set BUILDDIR=build
+
+if "%1" == "" goto help
+
+%SPHINXBUILD% >NUL 2>NUL
+if errorlevel 9009 (
+	echo.
+	echo.The 'sphinx-build' command was not found. Make sure you have Sphinx
+	echo.installed, then set the SPHINXBUILD environment variable to point
+	echo.to the full path of the 'sphinx-build' executable. Alternatively you
+	echo.may add the Sphinx directory to PATH.
+	echo.
+	echo.If you don't have Sphinx installed, grab it from
+	echo.https://www.sphinx-doc.org/
+	exit /b 1
+)
+
+%SPHINXBUILD% -M %1 %SOURCEDIR% %BUILDDIR% %SPHINXOPTS% %O%
+goto end
+
+:help
+%SPHINXBUILD% -M help %SOURCEDIR% %BUILDDIR% %SPHINXOPTS% %O%
+
+:end
+popd