-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
154 pietro integrates some best practices within cobra #166
Open
pietrodantuono
wants to merge
11
commits into
develop
Choose a base branch
from
154-pietro-integrates-some-best-practices-within-cobra
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
154 pietro integrates some best practices within cobra #166
pietrodantuono
wants to merge
11
commits into
develop
from
154-pietro-integrates-some-best-practices-within-cobra
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The invoke package has been added to the dev requirements. The "inv" command has been configured, and the test task has been implemented. Call inv test and take a look.
… of github.com:PythonPredictions/cobra into 154-pietro-integrates-some-best-practices-within-cobra
Run `inv qa` to test this functionality. CAVEAT: at the moment, qa runs flake8, pylint and mypy sequentially. Black is not run because it would modify the source code.
Run `inv nb` to test this functionality. CAVEAT: at the moment, nb runs on Linux and macOS, while still gives an error on Windows 11. It will be fixed soon.
This is not working on WSL, since the invoke executable is not being installed automatically when installing through |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration of git-changelog package and invoke command for easier development
Pietro integrates some best practices within Cobra #154
Additions made
Added some automated development tasks through the invoke command. To test it:
inv test
,inv qa
,inv nb
.Added git-changelog package dependency to simplify change log generation (https://pawamoy.github.io/git-changelog/).
How does the solution address the problem
This PR will:
inv nb
that automatically creates a jupyter environment in developer mode, i.e. every change in the cobra source code will be reflected immediately in the jupyter kernel.git-changelog
command which will be in the near future added as an invoke command.Linked issues
Resolves #154