Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/pep8 #132

Closed
wants to merge 10 commits into from
Closed

Fix/pep8 #132

wants to merge 10 commits into from

Conversation

ZlaTanskY
Copy link
Contributor

Fixing warnings received from PEP8 tools (see #131)
Typecheck is not yet fixed though...

@ZlaTanskY ZlaTanskY requested review from sborms and sandervh14 April 26, 2022 16:19
@ZlaTanskY ZlaTanskY marked this pull request as draft May 6, 2022 11:39
Base automatically changed from feat/pep8 to develop May 31, 2022 12:16
@sandervh14
Copy link
Contributor

sandervh14 commented Jun 1, 2022 •
edited
Loading

Hi Jano! :-)

This pull request is still a work in progress

  1. Interesting, how do you configure that on a pull request?
  2. I suppose this means you haven't finished this yet, and we shouldn't merge yet? Can I help finishing this (I've got some time), and if so, which tasks still remain? Or just the merge conflicts listed by Github below?

@ZlaTanskY
Copy link
Contributor Author

Hey Sander. Normally you can place a PR in "draft" on the right sidebar below Reviewers. Since this one is already in draft, you can click on Ready for review at the bottom of this PR, where you would normally merge the PR.
The only things that still need to be done are the remarks from typecheck and docstyle, so if you run make typecheck and make docstyle, these warnings still have to be tackled in order to follow the PEP8 style guide.
And indeed also the conflicts from new merges.

@ZlaTanskY ZlaTanskY mentioned this pull request Feb 24, 2023
Open
@ZlaTanskY
Copy link
Contributor Author

Obsolete and replaced by PR #149

@ZlaTanskY ZlaTanskY closed this Feb 24, 2023
@sandervh14 sandervh14 removed the request for review from sborms March 9, 2023 14:39
@sandervh14 sandervh14 added the enhancement New feature or request label Mar 9, 2023
@sandervh14 sandervh14 added this to the 2023-03 milestone Mar 9, 2023
@sandervh14 sandervh14 deleted the fix/pep8 branch March 13, 2023 11:12
@sandervh14
Copy link
Contributor

I wrongly assigned this PR during coarse allocation of issues and PRs to milestones.
Given Jano's comment:

Obsolete and replaced by PR #149
I'll unassign this PR from the March release.

@sandervh14 sandervh14 removed their request for review March 13, 2023 11:13
@sandervh14 sandervh14 removed this from the 2023-03 milestone Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ZlaTanskY ZlaTanskY

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZlaTanskY @sandervh14