Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nlpo3-python]: Fix build Python wheels #79

Merged
merged 23 commits into from
Nov 11, 2024

Conversation

bact
Copy link
Member

@bact bact commented Nov 10, 2024

To fix #64

Looks like we have issue with ciwheelbuild configuration.

  • Use actions-rust-lang/setup-rust-toolchain for Rust toolchain setup
  • Remove manual cache management, let setup-rust-toolchain and setup-python handle that
  • Update GitHub Actions dependencies

@bact
Copy link
Member Author

bact commented Nov 10, 2024

Looks like the workflow can at least start building on a number of platforms.

The error now is from the code, see #80, which can be fixed in another PR.

@bact bact changed the title Fix build Python wheels [nlpo3-python]: Fix build Python wheels Nov 10, 2024
@bact
Copy link
Member Author

bact commented Nov 11, 2024

Pass in Windows and macOS for all Python versions.

Failed in Linux in all Python versions.

  • "error: can't find Rust compiler" issue

Will merge as its current state and fix Linux issue in another PR.

@bact bact merged commit c776ea0 into PyThaiNLP:main Nov 11, 2024
50 of 66 checks passed
@bact bact deleted the fix-build-python-wheels branch November 11, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build-python-wheels.yml doesn't working
1 participant