938: Add code for smart contract from puffer launchpad #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9inpachi
force-pushed
the
938/smart-contract-code
branch
from
7b6be9d to
3cc395b
Compare
guestn
reviewed
May 21, 2024
| @@ -7,6 +7,11 @@ export default [ | |||
| ...tseslint.configs.recommended, | |||
| eslintPluginPrettierRecommended, | |||
| { | |||
| ignores: ['dist'], | |||
| ignores: ['dist/'], | |||
There was a problem hiding this comment.
We can do better than this later hopefully
lib/react/context/NetworkConfig.tsx
Outdated
| if (isConnected) { | ||
| const network = networkEnumToString(networkName).toLowerCase(); | ||
| const importedModule = await import(`../config/${network}.ts`).catch( | ||
| () => ({ default: defaultConfig }), |
There was a problem hiding this comment.
should we actually be erroring here if the network can't found
There was a problem hiding this comment.
This code is removed in the next PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code is copied over to the package and linting issues along with some other problems are fixed.
The API is not exported/exposed yet since the idea of the package is to expose contract methods differently. Which will be added in a follow up PR.