Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Handle toggleInProxy params dictionary as valid struct or reject #48

Merged
merged 2 commits into from
Nov 12, 2024
Merged

[iOS] Handle toggleInProxy params dictionary as valid struct or reject #48

merged 2 commits into from
Nov 12, 2024

Conversation

Enda-O
Copy link
Collaborator

@Enda-O Enda-O commented Nov 11, 2024

No description provided.

@Enda-O Enda-O requested review from adotkhan and tmgrask November 11, 2024 20:33
tmgrask
tmgrask reviewed Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@tmgrask tmgrask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me from RN perspective, I just wan't to make sure we're not unnecessarily logging the private key

@Enda-O
Copy link
Collaborator Author

Enda-O commented Nov 11, 2024 •
edited
Loading

While the ConduitParams logs are at trace level, and not sent with feedback, I think the sensitive field should have been redacted.

However, I've opted to simplify my solution by removing trace logs altogether, and JSON serialization & deserialization process.

@tmgrask tmgrask merged commit af5eb15 into refactor-params-mapping Nov 12, 2024
2 checks passed
@tmgrask tmgrask deleted the enda/ios-refactor-params-mapping branch November 12, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmgrask tmgrask tmgrask left review comments

@adotkhan adotkhan adotkhan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Enda-O @tmgrask @adotkhan