Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup parse_unary_expression. #28500

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Cleanup parse_unary_expression. #28500

merged 1 commit into from
Feb 3, 2025

Conversation

mikebenfield
Copy link
Collaborator

No functional changes; just changed to a recursive descent approach that's a bit easier to understand, and removed a big unnecessary match statement.

@mikebenfield mikebenfield requested a review from d0cd January 31, 2025 20:03
No functional changes; just changed to a recursive
descent approach that's a bit easier to understand, and
removed a big unnecessary match statement.
Copy link
Collaborator

@d0cd d0cd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mikebenfield mikebenfield merged commit d2677de into mainnet Feb 3, 2025
10 checks passed
@mikebenfield mikebenfield deleted the parse-cleanup branch February 3, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants