Refactored SymbolTable and related changes. #28488

mikebenfield · 2025-01-21T16:59:50Z

The SymbolTable design is now a little simpler, and local scopes don't have tables to store functions, structs, etc, since those are only globals anyway.

With this PR we:

Remove the symbol table json code.
Revise code catching assignments in conditionals in async functions. Previously, code like this:

if x {
  let y: u8 = 1u8;
  {
    y = 2u8;
  }
}

would trigger the error, but it should actually pass.

Can use locators for local records and mappings
Remove the N type parameter in TypeChecker. Instead, we have a NetworkLimits struct which contains the values the TypeChecker will actually use. This cuts down on code bloat a bit.

tests/tests/compiler/function/async_conditional.leo

tests/expectations/compiler/function/async_conditional.out

compiler/passes/src/type_checking/scope_state.rs

compiler/passes/src/code_generation/visit_expressions.rs

compiler/passes/src/code_generation/visit_type.rs

compiler/passes/src/common/symbol_table/variable_symbol.rs

compiler/passes/src/common/symbol_table/mod.rs

compiler/passes/src/loop_unrolling/unroll_program.rs

compiler/passes/src/loop_unrolling/unroll_statement.rs

compiler/passes/src/symbol_table_creation.rs

d0cd · 2025-01-22T21:52:50Z

compiler/passes/src/type_checking/check_expressions.rs

@@ -1008,6 +1009,6 @@ impl<'a, N: Network> ExpressionVisitor<'a> for TypeChecker<'a, N> {
    }

    fn visit_unit(&mut self, _input: &'a UnitExpression, _additional: &Self::AdditionalInput) -> Self::Output {
-        unreachable!("Unit expressions should not exist in normal code");


I believe unit expression should not exist at this point.

They actually do exist (not explicitly specified by the user) in return statements. At least for now I'll leave this as is.

compiler/passes/src/type_checking/checker.rs

d0cd

I like the design of the new symbol table and it greatly simplifies scope management, while addressing a number of issues. I left a few comments and nits, otherwise LGTM!

The SymbolTable design is now a little simpler, and local scopes don't have tables to store functions, structs, etc, since those are only globals anyway. Remove the symbol table json code. Revise code catching assignments in conditionals in async functions. Previously, code like this: if x { let y: u8 = 1u8; { y = 2u8; } } would trigger the error, but it should actually pass. Can use locators for local records and mappings Remove the N type parameter in TypeChecker. Instead, we have a `NetworkLimits` struct which contains the values the TypeChecker will actually use. This cuts down on code bloat a bit.

mikebenfield requested a review from d0cd January 21, 2025 16:59

mikebenfield force-pushed the symbol-table-squash branch 2 times, most recently from 8810f56 to aeabc3a Compare January 21, 2025 17:51