Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leo Deploy #26901

Merged
merged 55 commits into from
Feb 12, 2024
Merged

Leo Deploy #26901

merged 55 commits into from
Feb 12, 2024

Conversation

evan-schott
Copy link
Contributor

@evan-schott evan-schott commented Jan 5, 2024

  • TLDR:
    • cd into project directory and type leo deploy
  • Motivation:
    • Make it super easy for new developers to deploy their programs
      • A lot of defaults preselected
      • If devs want more options they can just use the snarkos tool
    • Not just a wrapper around snarkos developer deploy, the reason its being built in Leo is so that it can recursively deploy local dependencies.
      • This is an absolute pain to do using snarkos because have to move all the local dependencies into their own folders, and name them main.aleo with imports directory of their imports
  • Defaults:
    • Endpoint: Aleo node
    • Builds project if unbuilt
    • Recursively deploys imports
      • Already know all the paths to local directories
      • Do quick check to see if the local project name already taken on chain

@evan-schott evan-schott requested a review from d0cd January 9, 2024 00:48
Base automatically changed from feat/stubs to testnet3 January 10, 2024 02:01
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 114 lines in your changes are missing coverage. Please review.

Comparison is base (e0632d6) 76.05% compared to head (95d95f2) 75.65%.

Files Patch % Lines
compiler/ast/src/stub/function_stub.rs 17.94% 32 Missing ⚠️
leo/cli/cli.rs 81.31% 17 Missing ⚠️
compiler/passes/src/common/symbol_table/mod.rs 58.33% 15 Missing ⚠️
compiler/ast/src/struct/mod.rs 56.25% 7 Missing ⚠️
...ompiler/passes/src/common/symbol_table/location.rs 50.00% 5 Missing ⚠️
compiler/passes/src/type_checking/checker.rs 88.37% 5 Missing ⚠️
...rors/src/errors/type_checker/type_checker_error.rs 20.00% 4 Missing ⚠️
leo/cli/commands/deploy.rs 0.00% 3 Missing ⚠️
compiler/ast/src/mapping/mod.rs 33.33% 2 Missing ⚠️
compiler/ast/src/types/array.rs 0.00% 2 Missing ⚠️
... and 16 more
Additional details and impacted files
@@             Coverage Diff              @@
##           testnet3   #26901      +/-   ##
============================================
- Coverage     76.05%   75.65%   -0.41%     
============================================
  Files           200      203       +3     
  Lines          6800     7049     +249     
  Branches       6800     7049     +249     
============================================
+ Hits           5172     5333     +161     
- Misses         1628     1716      +88     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@d0cd d0cd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We will revisit this feature later.

leo/cli/cli.rs Outdated
Comment on lines 71 to 90
#[clap(about = "Deploy a program")]
Deploy {
#[clap(flatten)]
command: Deploy,
},
#[clap(about = "Add a new on-chain or local dependency to the current package.")]
Add {
#[clap(flatten)]
command: Add,
},
#[clap(about = "Compile the current package as a program")]
Build {
#[clap(flatten)]
command: Build,
},
#[clap(about = "Clean the output directory")]
Clean {
#[clap(flatten)]
command: Clean,
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: lets keep these in alphabetic order.

@d0cd d0cd merged commit a2e3155 into testnet3 Feb 12, 2024
14 of 15 checks passed
@d0cd d0cd deleted the feat/leo-deploy branch February 12, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants