fixed broken avatar position updated for story NPCs

ProjektAdLer · Feb 21, 2024 · 25975f7 · 25975f7
1 parent f8b2294
commit 25975f7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 9 deletions.
diff --git a/src/Components/Core/Presentation/Babylon/LearningSpaces/LearningSpacePresenter.ts b/src/Components/Core/Presentation/Babylon/LearningSpaces/LearningSpacePresenter.ts
@@ -24,7 +24,7 @@ export default class LearningSpacePresenter implements ILearningSpacePresenter {
   private decorationBuilder: IDecorationBuilder;
   private doorPresenters: IDoorPresenter[] = [];
   private elementPresenters: ILearningElementPresenter[] = [];
-  private storyNPCPresenters: IStoryNPCPresenter;
+  private storyNPCPresenters: IStoryNPCPresenter[] = [];
 
   constructor(private viewModel: LearningSpaceViewModel) {
     if (!this.viewModel) {
@@ -56,11 +56,8 @@ export default class LearningSpacePresenter implements ILearningSpacePresenter {
     for (const elementPresenter of this.elementPresenters) {
       elementPresenter.onAvatarPositionChanged(position, interactionRadius);
     }
-    if (this.storyNPCPresenters)
-      this.storyNPCPresenters.onAvatarPositionChanged(
-        position,
-        interactionRadius
-      );
+    for (const npcPresenter of this.storyNPCPresenters)
+      npcPresenter.onAvatarPositionChanged(position, interactionRadius);
   }
 
   private async fillLearningElementSlots(
@@ -178,7 +175,7 @@ export default class LearningSpacePresenter implements ILearningSpacePresenter {
 
         await this.director.buildAsync(storyNPCBuilder);
 
-        this.storyNPCPresenters = storyNPCBuilder.getPresenter();
+        this.storyNPCPresenters.push(storyNPCBuilder.getPresenter());
       }
     }
   }

diff --git a/src/Components/Core/Presentation/Babylon/StoryNPC/IStoryNPCPresenter.ts b/src/Components/Core/Presentation/Babylon/StoryNPC/IStoryNPCPresenter.ts
@@ -4,6 +4,4 @@ import { StoryElementType } from "src/Components/Core/Domain/Types/StoryElementT
 
 export default interface IStoryNPCPresenter extends ILearningWorldAdapter {
   onAvatarPositionChanged(position: Vector3, interactionRadius: number): void;
-  onStoryElementCutSceneTriggered(storyType: StoryElementType): void;
-  onStoryElementCutSceneFinished(): void;
 }