Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug/issue 1410 handle static asset bundling of multiple usages of new URL and import.meta.url in the same file #1412

Merged
merged 2 commits into from
Feb 13, 2025
Merged

bug/issue 1410 handle static asset bundling of multiple usages of new URL and import.meta.url in the same file #1412

merged 2 commits into from
Feb 13, 2025

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Feb 8, 2025 •
edited
Loading

Related Issue

resolves #1410

Documentation

N / A

Summary of Changes

  1. Avoid race condition / stale contents from being worked upon for string replacements
  2. Add test case

image

@thescientist13 thescientist13 added bug Something isn't working CLI labels Feb 8, 2025
@thescientist13 thescientist13 merged commit 929d01f into master Feb 13, 2025
10 checks passed
@thescientist13 thescientist13 deleted the bug/issue-1410-multiple-usages-of-new-URL-not-getting-bundled branch February 13, 2025 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

multiple usages of new URL + import.meta.url in same file only bundles the last occurrence
1 participant
@thescientist13