-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update "pathology/tumor_detection/ignite/profiling_camelyon_pipeline.ipynb" #1673
Conversation
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @KumoLiu! I have tested it on my machine and all works fine.
@KumoLiu I see an error in the CI but I don't see it when running locally. Can it be due the installed nsight version? Can you take a look before merging? |
The complaint is |
It’s wired, I don’t see any reason why the file is not exist. Also, what could be the reasons for it not executing immediately. |
I would think papermill would run all command invocations otherwise many other notebooks would fail. How large is the generated csv? If the container runs out of space and tries to write the file it may silently do nothing, but this file would have to be really big. We could have a check right after |
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: YunLiu <[email protected]>
works well in the 24.02 PyTorch image, close for now. |
…ipynb" (Project-MONAI#1673) Fixes # . ### Description Update the usage of nvtx in "tumor_detection_camelyon" ### Checks <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [ ] Avoid including large-size files in the PR. - [ ] Clean up long text outputs from code cells in the notebook. - [ ] For security purposes, please check the contents and remove any sensitive info such as user names and private key. - [ ] Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the `./figure` folder - [ ] Notebook runs automatically `./runner.sh -t <path to .ipynb file>` --------- Signed-off-by: YunLiu <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Fixes # .
Description
Update the usage of nvtx in "tumor_detection_camelyon"
Checks
./figure
folder./runner.sh -t <path to .ipynb file>