Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "pathology/tumor_detection/ignite/profiling_camelyon_pipeline.ipynb" #1673

Merged
merged 14 commits into from
Mar 21, 2024

Conversation

KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Mar 20, 2024

Fixes # .

Description

Update the usage of nvtx in "tumor_detection_camelyon"

Checks

  • Avoid including large-size files in the PR.
  • Clean up long text outputs from code cells in the notebook.
  • For security purposes, please check the contents and remove any sensitive info such as user names and private key.
  • Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the ./figure folder
  • Notebook runs automatically ./runner.sh -t <path to .ipynb file>

KumoLiu added 2 commits March 20, 2024 22:18
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@bhashemian bhashemian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @KumoLiu! I have tested it on my machine and all works fine.

@bhashemian
Copy link
Member

bhashemian commented Mar 20, 2024

@KumoLiu I see an error in the CI but I don't see it when running locally. Can it be due the installed nsight version? Can you take a look before merging?

@ericspod
Copy link
Member

The complaint is FileNotFoundError: [Errno 2] No such file or directory: 'profile_report_nvtx_pushpop_sum.csv'. It looks like this file is generated by the nsys call, maybe this isn't running now for some reason? The name changes in the PR look correct.

@KumoLiu
Copy link
Contributor Author

KumoLiu commented Mar 20, 2024

It’s wired, I don’t see any reason why the file is not exist. Also, what could be the reasons for it not executing immediately.

@ericspod
Copy link
Member

I would think papermill would run all command invocations otherwise many other notebooks would fail. How large is the generated csv? If the container runs out of space and tries to write the file it may silently do nothing, but this file would have to be really big. We could have a check right after nsys stats to check that the file was created: assert os.path.isfile("profile_report_nvtx_pushpop_sum.csv"). For testing in the CICD environment we could temporarily add !ls -lh right before that to see what the file structure looks like.

KumoLiu and others added 12 commits March 21, 2024 00:35
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
@KumoLiu
Copy link
Contributor Author

KumoLiu commented Mar 21, 2024

works well in the 24.02 PyTorch image, close for now.

@KumoLiu KumoLiu merged commit 89ca2f1 into Project-MONAI:main Mar 21, 2024
6 checks passed
@KumoLiu KumoLiu deleted the nvtx branch March 21, 2024 16:28
boneseva pushed a commit to boneseva/MONAI-tutorials that referenced this pull request Apr 21, 2024
…ipynb" (Project-MONAI#1673)

Fixes # .

### Description
Update the usage of nvtx in "tumor_detection_camelyon"

### Checks
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [ ] Avoid including large-size files in the PR.
- [ ] Clean up long text outputs from code cells in the notebook.
- [ ] For security purposes, please check the contents and remove any
sensitive info such as user names and private key.
- [ ] Ensure (1) hyperlinks and markdown anchors are working (2) use
relative paths for tutorial repo files (3) put figure and graphs in the
`./figure` folder
- [ ] Notebook runs automatically `./runner.sh -t <path to .ipynb file>`

---------

Signed-off-by: YunLiu <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants