Switch Scribbles optimisation to numpymaxflow #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: masadcv <[email protected]>
Signed-off-by: masadcv <[email protected]>
SachidanandAlle
approved these changes
Apr 23, 2022
|
The basic functionality looks good to me.. you can continue to improve further on accuracy (specially edges) as another task. |
|
Many thanks! Will looking into improving this further in coming days |
|
FYI.. I have verified it on both windows and ubuntu... windows all good.. |
|
Thanks for confirming this! I really need to set everything up in a Windows env... |
Douwe-Spaanderman
pushed a commit
to Douwe-Spaanderman/MONAILabel
that referenced
this pull request
Dec 9, 2022
* switch to numpymaxflow Signed-off-by: masadcv <[email protected]> * fix flake8 Signed-off-by: masadcv <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: masadcv [email protected]
Recent update to scribbles added torchmaxflow as dependency. As it is targetted for specific pytorch versions, it limits the usable pytorch version to specific versions (see #746).
Also see related discussion to this at: #731
This PR changes the dependency to numpymaxflow - a numpy-based maxflow implementation. This will release any pytorch version dependencies from monai label.
I have tested this on Ubuntu. May need to be tested for installation and a scribbles example on Windows.