Remove Simplecrf dependency, remove scribbles functions depending on it #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecrf Signed-off-by: masadcv <[email protected]>
Signed-off-by: masadcv <[email protected]>
Signed-off-by: masadcv <[email protected]>
SachidanandAlle
approved these changes
Apr 5, 2022
Signed-off-by: masadcv <[email protected]>
This was
linked to
issues
Apr 5, 2022
|
Will the scribble function be removed permanently or just temporarily? |
|
Hi @eufmike , Thanks for your interest! I already have a PR to restore the functionality for scribbles #731 |
|
Hi @masadcv, got it, and thank you for the prompt response! |
Douwe-Spaanderman
pushed a commit
to Douwe-Spaanderman/MONAILabel
that referenced
this pull request
Dec 9, 2022
…it (Project-MONAI#727) * remove simplecrf dependency, remove scribbles func depending on simplecrf Signed-off-by: masadcv <[email protected]> * remove scribbles/infer.py Signed-off-by: masadcv <[email protected]> * remove histogram based graphcut scribbles Signed-off-by: masadcv <[email protected]> * attempting to fix codeformat issues Signed-off-by: masadcv <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#726 reported issues with incompatible license for one of the dependencies within SimpleCRF library that is used for scribbles optimisation
This PR removes SimpleCRF as dependency, as a result it also removes scribbles functions that depended on Simplecrf
Signed-off-by: masadcv [email protected]
cc: @tvercaut