Quick fix for simplecrf imports #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: masadcv <[email protected]>
|
@SachidanandAlle I made all SImpleCRF imports optional. Please give it a try by uninstalling SimpleCRF and running any app. On my end this exp runs fine. |
rijobro
reviewed
Feb 4, 2022
monailabel/scribbles/transforms.py
Outdated
| @@ -31,6 +30,10 @@ | |||
| maxflow3d, | |||
| ) | |||
|
|
|||
| densecrf, _ = optional_import("dennseCRF") | |||
| densecrf3d, _ = optional_import("denseCRF3D") | |||
There was a problem hiding this comment.
here, you could use:
Suggested change
| densecrf3d, _ = optional_import("denseCRF3D") | |
| densecrf3d, has_densecrf3d = optional_import("denseCRF3D") |
and then you could use has_densecrf3d elsewhere to display an error if the user tries to use scribbles.
There was a problem hiding this comment.
thanks! will update this.
Signed-off-by: masadcv <[email protected]>
SachidanandAlle
approved these changes
Feb 4, 2022
|
This solves one part of the problem... when SimpleCRF is installed but import fails due to xyz reasons... |
Closed
Douwe-Spaanderman
pushed a commit
to Douwe-Spaanderman/MONAILabel
that referenced
this pull request
Dec 9, 2022
* quick fix for simplecrf imports Signed-off-by: masadcv <[email protected]> * use has_import to give a nice ImportError Signed-off-by: masadcv <[email protected]> Co-authored-by: SACHIDANAND ALLE <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: masadcv [email protected]
Work around for #605 until the error is debugged.