Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zarr compression tests only with versions before 3.0 #8319

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

Zarr compression tests only with versions before 3.0 #8319

wants to merge 6 commits into from
+33 −27

Conversation

ericspod
Copy link
Member

@ericspod ericspod commented Jan 29, 2025 •
edited
Loading

Fixes #8298.

Description

This includes the tests for the compressor argument when testing with Zarr before version 3.0 when this argument was deprecated. A fix to upgrade the version of pycln used is also included.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AttributeError: module 'zarr.storage' has no attribute 'DirectoryStore'
1 participant
@ericspod